Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update branch-pattern matching #3030

Merged

Conversation

blocktrron
Copy link
Member

@blocktrron blocktrron commented Oct 19, 2023

github: restrict branch-triggers on specific branches

In #2997 it was pointed out the current branch-trigger matches more
branches than the release-branches. Retrict the match-pattern to only
cover release-branches

Also only trigger builds on the next-branch and not branches prefixed
with this name.

Link: #2997 (comment)


github: add workflow-dispatch trigger for build workflow

Add a workflow-dispatch trigger to the build-workflow to enable
triggering build-tests on branches not covered from the match
pattern.


github: trigger ci-build when altering ci

It makes sense to run CI build-tests in case the CI itself is altered.

In freifunk-gluon#2997 it was pointed out the current branch-trigger matches more
branches than the release-branches. Retrict the match-pattern to only
cover release-branches

Also only trigger builds on the next-branch and not branches prefixed
with this name.

Link: freifunk-gluon#2997 (comment)

Signed-off-by: David Bauer <[email protected]>
Add a workflow-dispatch trigger to the build-workflow to enable
triggering build-tests on branches not covered from the match
pattern.

Signed-off-by: David Bauer <[email protected]>
Copy link
Member

@skorpy2009 skorpy2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks lovely to me! 😍

contrib/actions/generate-target-filters.py Outdated Show resolved Hide resolved
.github/workflows/build-gluon.yml Show resolved Hide resolved
It makes sense to run CI build-tests in case the CI itself is altered.

Signed-off-by: David Bauer <[email protected]>
@blocktrron blocktrron merged commit be86299 into freifunk-gluon:master Oct 21, 2023
37 checks passed
@blocktrron blocktrron deleted the ci-restrictive-target-match branch October 21, 2023 11:10
@blocktrron blocktrron restored the ci-restrictive-target-match branch October 21, 2023 11:10
@blocktrron blocktrron deleted the ci-restrictive-target-match branch October 21, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants